"make installcheck" fails in src/test/recovery

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: "make installcheck" fails in src/test/recovery
Date: 2019-04-18 05:45:45
Message-ID: 17806.1555566345@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Up until quite recently, it worked to do "make installcheck" in
src/test/recovery, following the instructions in the README
file there:

NOTE: You must have given the --enable-tap-tests argument to configure.
Also, to use "make installcheck", you must have built and installed
contrib/test_decoding in addition to the core code.

Run
make check
or
make installcheck
You can use "make installcheck" if you previously did "make install".
In that case, the code in the installation tree is tested. With
"make check", a temporary installation tree is built from the current
sources and then tested.

Now, however, the 016_min_consistency.pl test is falling over,
with symptoms indicating that it expects to have the pageinspect
extension installed as well:

error running SQL: 'psql:<stdin>:2: ERROR: could not open extension control fil
e "/home/postgres/testversion/share/extension/pageinspect.control": No such file
or directory'
while running 'psql -XAtq -d port=64106 host=/tmp/KaoBFubKfw dbname='postgres' -
f - -v ON_ERROR_STOP=1' with sql '
CREATE EXTENSION pageinspect;
...

Is this extra dependency actually essential? I'm not really
happy about increasing the number of moving parts in this test.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2019-04-18 06:12:38 Re: New vacuum option to do only freezing
Previous Message Pavel Stehule 2019-04-18 05:20:37 proposal: psql PSQL_TABULAR_PAGER variable