From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH][PROPOSAL] Add enum releation option type |
Date: | 2018-11-01 15:26:20 |
Message-ID: | 1772537.zFQtMGATT1@x200m |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
В письме от 1 ноября 2018 11:10:14 пользователь Tom Lane написал:
> >>> I see you lost the Oxford comma:
> >>>
> >>> -DETAIL: Valid values are "on", "off", and "auto".
> >>> +DETAIL: Valid values are "auto", "on" and "off".
> >>>
> >>> Please put these back.
> >>
> >> Actually that's me who have lost it. The code with oxford comma would be
> >> a
> >> bit more complicated. We should put such coma when we have 3+ items and
> >> do not put it when we have 2.
> >>
> >> Does it worth it?
> >
> > In my opinion, it is worth it.
>
> Uh ... I've not been paying attention to this thread, but this exchange
> seems to be about somebody constructing a message like that piece-by-piece
> in code. This has got to be a complete failure from the translatability
> standpoint. See
>
> https://www.postgresql.org/docs/devel/static/nls-programmer.html#NLS-GUIDELI
> NES
It's a very good reason...
In this case the only solution I can see is
DETAIL: Valid values are: "value1", "value2", "value3".
Where list '"value1", "value2", "value3"' is built in runtime but have no any
bindnings to any specific language. And the rest of the message is
'DETAIL: Valid values are: %s' which can be properly translated.
--
Do code for fun.
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-11-01 15:27:23 | Re: backend crash on DELETE, reproducible locally |
Previous Message | Karsten Hilbert | 2018-11-01 15:21:15 | Re: backend crash on DELETE, reproducible locally |