Re: TAP tests - installcheck vs check

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP tests - installcheck vs check
Date: 2017-04-25 15:13:54
Message-ID: 17622.1493133234@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 04/25/2017 10:45 AM, Robert Haas wrote:
>>> I agree entirely that it's confusing as heck. +1 for inventing a new name.

>> Yeah. I would have expected installcheck to just skip any tests that
>> don't make sense against an already-installed cluster. I would not
>> expect it to run those tests against some cluster other than the
>> installed cluster. That seems super-weird.

> I'm in the process of moving all the buildfarm tests to use check
> instead of installcheck, but in such a way that it doesn't constantly
> generate redundant installs.

But is that something only of interest to the buildfarm, or should we
do something in the Makefile infrastructure to make it more generally
available?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2017-04-25 15:17:23 Re: PG 10 release notes
Previous Message Dmitriy Sarafannikov 2017-04-25 15:13:12 [PROPOSAL] Use SnapshotAny in get_actual_variable_range