Re: relative_path() seems overly complicated and buggy

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: relative_path() seems overly complicated and buggy
Date: 2004-11-06 23:12:22
Message-ID: 17614.1099782742@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Bruce Momjian wrote:
>> Tom Lane wrote:
>>> What I'd like to do is simplify it to just check for exact equality
>>> up through the last directory separator in bin_path. Any objections?
>>
>> If you can simplify it, feel free. I found that code much more complex
>> than I liked but couldn't simplify it. Originally I thought that would
>> be used in more generic places but that hasn't happened.

> Let me try to clean it up first by using canonicalize_path() and
> comparing the result.

I already checked in the simplification.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-11-06 23:14:41 Re: Increasing the length of pg_stat_activity.current_query...
Previous Message Simon Riggs 2004-11-06 22:05:20 Proposal for Recover mode in pg_ctl (in 8.0)