Re: Request for new column in pg_namespace

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Isaac Morland <isaac(dot)morland(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Ron Johnson <ronljohnsonjr(at)gmail(dot)com>, pgsql-general <pgsql-general(at)postgresql(dot)org>
Subject: Re: Request for new column in pg_namespace
Date: 2024-12-15 19:20:23
Message-ID: 1753818.1734290423@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Isaac Morland <isaac(dot)morland(at)gmail(dot)com> writes:
> On Sun, 15 Dec 2024 at 12:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> What I'd suggest as an improvement that could be implemented
>> immediately is to wrap the checks in a user-defined function
>> like "is_system_schema(nspname name)".

> Would it make sense to make the parameter be of type regnamespace?

Meh ... you could, but what the function really needs is the name.
Getting from regnamespace (which is an OID) to the name would incur
an extra syscache lookup. Admittedly, if it removes the need for
the calling query to join to pg_namespace at all, you'd probably
come out about even --- the net effect would be about like a
hashjoin to pg_namespace, I think, since the syscache would act
like the inner hashtable of a hashjoin.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Isaac Morland 2024-12-15 20:05:46 Re: Request for new column in pg_namespace
Previous Message Ron Johnson 2024-12-15 17:46:42 Re: Request for new column in pg_namespace