From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Merlin Moncure" <mmoncure(at)gmail(dot)com> |
Cc: | "Andrew Chernow" <ac(at)esilo(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: libpq object hooks |
Date: | 2008-05-16 15:24:10 |
Message-ID: | 17534.1210951450@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
"Merlin Moncure" <mmoncure(at)gmail(dot)com> writes:
> Switch, plus struct (basically a union) will do the trick nicely. Can
> it be a formal union, or is it better as a void*?
I don't think a union buys much notational convenience or safety here,
although admittedly it's a close question. In one case you're trusting
to cast the pointer to the appropriate type, in the other you're
trusting to use the right union member. One advantage of separate
structs is that there's no reason not to make the struct type names
long enough to be clear, whereas there's a very strong notational
temptation to make union member names short, because you'll be typing
them a lot.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2008-05-16 15:26:13 | Re: libpq object hooks |
Previous Message | Peter Eisentraut | 2008-05-16 15:21:42 | Re: ecpg localization |
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2008-05-16 15:26:13 | Re: libpq object hooks |
Previous Message | Andrew Dunstan | 2008-05-16 15:21:15 | Re: libpq object hooks |