| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Erroneous -Werror=missing-braces on old GCC |
| Date: | 2023-12-25 04:23:49 |
| Message-ID: | 1749748.1703478229@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
>> I came across the 'missing braces' warning again when building master
>> (0a93f803f4) on old GCC (4.8.5).
> On the one hand, it's probably pointless to worry about buggy
> warnings from ancient compilers ...
Actually, after checking the buildfarm, I see that
arowana
ayu
batfish
boa
buri
demoiselle
dhole
dragonet
idiacanthus
lapwing
mantid
petalura
rhinoceros
shelduck
siskin
tanager
topminnow
xenodermus
are all bitching about this (with a couple different spellings
of the warning). So this is absolutely something to fix, and
I'm rather surprised that nobody noticed it during the development
of 174c48050.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-12-25 04:47:47 | pg_basebackup has an accidentaly separated help message |
| Previous Message | Tom Lane | 2023-12-25 03:57:33 | Re: Erroneous -Werror=missing-braces on old GCC |