Build failed in Jenkins: pgadmin4-master-python33 #121

See <https://jenkins.pgadmin.org/job/pgadmin4-master-python33/121/display/redirect?page=changes>

Changes:

[Dave Page] Add numerous missing checks to ensure objects really exist when we think

------------------------------------------
[...truncated 263.10 KB...]
Get materialized view under schema node ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest (pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest (pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest (pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest (pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... 2017-05-25 20:59:38,980: ERROR pgadmin: global name 'sql' is not defined
Traceback (most recent call last):
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web/pgadmin/browser/server_groups/servers/tablespaces/__init__.py",> line 357, in update
if not isinstance(sql, (str, unicode)):
NameError: global name 'sql' is not defined
pgAdmin 4 - Application Initialisation
======================================

NOTE: Configuring authentication for DESKTOP mode.
Please check output in file: <https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web/regression/regression.log>

FAIL
runTest (pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
Check Server Group Node ... ok
runTest (pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Test versioned template loader ... ok
runTest (regression.python_test_utils.sql_template_test_base.SQLTemplateTestBase)
parent test class ... ok

======================================================================
FAIL: runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node
----------------------------------------------------------------------
Traceback (most recent call last):
File "<https://jenkins.pgadmin.org/job/pgadmin4-master-python33/ws/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_put.py",> line 58, in runTest
self.assertEquals(put_response.status_code, 200)
AssertionError: 500 != 200

----------------------------------------------------------------------
Ran 158 tests in 25.687s

FAILED (failures=1)

======================================================================
Test Result Summary
======================================================================

EDB Postgres AS 9.6:

157 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
0 tests skipped

EDB Postgres AS 9.5:

157 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
0 tests skipped

PostgreSQL 9.5:

145 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
12 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

145 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
12 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)

EDB Postgres AS 9.4:

157 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
0 tests skipped

PostgreSQL 9.6:

145 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
12 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)

EDB Postgres AS 9.2:

145 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
12 tests skipped:
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ViewsGetTestCase (Get materialized view under schema node)
ResourceGroupsGetTestCase (Get resource groups)
ViewsDeleteTestCase (Delete materialized view under schema node)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
ViewsAddTestCase (Add materialized view under schema node)
ResourceGroupsDeleteTestCase (Delete resource groups)
ViewsUpdateTestCase (Update materialized view under schema node)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)

EDB Postgres AS 9.3:

153 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
4 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsAddTestCase (Add resource groups)

PostgreSQL 9.3:

145 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
12 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.2:

137 tests passed
1 test failed:
TableSpaceUpdateTestCase (Check Tablespace Node)
20 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
ViewsGetTestCase (Get materialized view under schema node)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ViewsDeleteTestCase (Delete materialized view under schema node)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
SynonymAddTestCase (Default Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
PackageAddTestCase (Fetch Package Node URL)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
ViewsAddTestCase (Add materialized view under schema node)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)

======================================================================

ERROR: Error detected when running the Python tests.
ERROR: Error detected when running the Python tests.
Process leaked file descriptors. See http://wiki.jenkins-ci.org/display/JENKINS/Spawning+processes+from+build for more information
Build step 'Execute shell' marked build as failure