From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Artus de benque <artusdebenque(at)gmail(dot)com>, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Postgresql bug report - unexpected behavior of suppress_redundant_updates_trigger |
Date: | 2017-06-19 16:20:21 |
Message-ID: | 1742.1497889221@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jun 19, 2017 at 11:59 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't think it's a bug, I think it's an intentional design tradeoff.
>> To suppress an update in this case, the trigger would have to grovel
>> through the individual fields and detoast them before comparing.
>> That would add a lot of cycles, and only seldom add successes.
>>
>> Possibly we should adjust the documentation so that it doesn't imply
>> that this trigger guarantees to suppress every no-op update.
> That doesn't sound like a very plausible argument to me. I don't
> think that a proposal to add a function named
> sometimes_suppress_redundant_updates_trigger() would've attracted many
> votes.
You'd be wrong. The entire point of this trigger is to save cycles,
so having it eat a lot of cycles only to fail is not an improvement.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2017-06-19 16:31:43 | Re: BUG #14714: long running sessions from remote instance seems to hang some times |
Previous Message | Robert Haas | 2017-06-19 16:05:31 | Re: [HACKERS] Postgresql bug report - unexpected behavior of suppress_redundant_updates_trigger |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-06-19 16:30:12 | Re: WIP: Data at rest encryption |
Previous Message | Tom Lane | 2017-06-19 16:18:04 | Re: Decimal64 and Decimal128 |