| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: narwhal and PGDLLIMPORT |
| Date: | 2014-02-08 23:12:10 |
| Message-ID: | 17405.1391901130@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> I think that there's a small problem with your patch, namely that you
> made the explicit PGDLLEXPORT definition empty, but that's currently
> used in fmgr.h for the function and module magic, I think we actually
> need those to be __declspec(dllexport)ed when building an extension,
> right?
The comment next to that says that we're relying on --export-all.
If PGDLLEXPORT were being used for other contrib-module functions,
you would have a point, but AFAICS no one ever bothered.
(If this patch works, we could go around and clean up stuff like
that, but that's a bit premature at this point...)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2014-02-09 00:49:31 | Re: Changeset Extraction v7.5 |
| Previous Message | Andres Freund | 2014-02-08 23:08:26 | Re: Changeset Extraction v7.5 |