| From: | Ahmed Ashour <a8087027(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Subject: | Re: Document How Commit Handles Aborted Transactions |
| Date: | 2025-02-14 21:00:35 |
| Message-ID: | 173956683519.300960.13575991472601097530.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed
Summary:
---------
The patch adds documentation to clarify how PostgreSQL handles aborted transactions during the commit process. The changes are clear and improve the existing documentation.
Testing:
--------
1. Manually applied the patch to the latest master branch (commit 4cffc93).
2. Fixed SGML structure issues in `advanced.sgml` and `commit.sgml` by wrapping `<varlistentry>` in `<variablelist>`.
3. Rebuilt the documentation using `make html`.
4. Verified the new sections are present and correctly formatted in the generated HTML.
Feedback:
---------
- The patch was manually applied due to conflicts in `advanced.sgml` and `commit.sgml`.
- Fixed invalid SGML structure by wrapping `<varlistentry>` in `<variablelist>`.
- The documentation is accurate and follows PostgreSQL’s style guidelines.
- No additional issues were found.
Recommendation:
---------------
Ready for committer. No objections.
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-02-14 21:40:58 | Re: [PATCH] SVE popcount support |
| Previous Message | Alexander Lakhin | 2025-02-14 21:00:00 | Re: generic plans and "initial" pruning |