Re: DROP OWNED BY fails to clean out pg_init_privs grants

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Егор Чиндяскин <kyzevan23(at)mail(dot)ru>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, David G(dot) Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <nmisch(at)google(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>
Subject: Re: DROP OWNED BY fails to clean out pg_init_privs grants
Date: 2024-09-18 04:31:27
Message-ID: 1738911.1726633887@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?UTF-8?B?0JXQs9C+0YAg0KfQuNC90LTRj9GB0LrQuNC9?= <kyzevan23(at)mail(dot)ru> writes:
> This query does not expect that test database may already contain some information about custom user that ran test_pg_dump-running.

I'm perfectly content to reject this as being an abuse of the test
case. Our TAP tests are built on the assumption that they use
databases created within the test case. Apparently, you've found a
way to use the meson test infrastructure to execute a TAP test in
the equivalent of "make installcheck" rather than "make check" mode.
I am unwilling to buy into the proposition that our TAP tests should
be proof against doing that after making arbitrary changes to the
database's initial state. If anything, the fact that this is possible
is a bug in our meson scripts.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-09-18 04:43:41 Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation
Previous Message Amit Kapila 2024-09-18 04:29:10 Re: Conflict detection for update_deleted in logical replication