Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: 2020-01-05 02:15:20
Message-ID: 1736.1578190520@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> Peter Geoghegan <pg(at)bowt(dot)ie> writes:
>> Once I comment out the following two lines from ~/.inputrc, everything
>> works fine on
>> HEAD + HEAD-unset-TERM-in-tab-completion-test.patch:
>> set colored-completion-prefix on
>> set colored-stats on

> Hm. I wonder how it is that that leads to ignoring the TERM environment?

A bit of digging says that readline's color support is just hard-wired
to use xterm-style escapes -- it doesn't look like there's any connection
to terminfo at all. See the _rl_color_indicator[] data structure.
The \e[...m and \e[K escape sequences can both be found there.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-01-05 02:16:23 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Previous Message Tom Lane 2020-01-05 01:57:28 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-01-05 02:16:23 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Previous Message Tom Lane 2020-01-05 01:57:28 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.