From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Noah Misch <noah(at)leadboat(dot)com> |
Subject: | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |
Date: | 2021-10-07 19:44:48 |
Message-ID: | 173186.1633635888@sss.pgh.pa.us |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
[ cc'ing Craig and Noah, as author/committer of the existing text ]
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 7 Oct 2021, at 21:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> BTW, looking at that a second time, I wonder if that advice is
>> really of any use.
> Yeah, I would have to agree. Reading that again I think what it perhaps should
> be saying is that 5.8.3 is the Perl API level that the testcode must conform
> to, but they should run with basically whichever recent Perl you have handy as
> long as the required modules are installed. Not that we expect developers to
> run 5.8.3 when executing TAP tests.
Yeah. I propose that what might be more useful than the existing last
section of src/test/perl/README is something along the lines of:
Avoid using any bleeding-edge Perl features. We have buildfarm
animals running Perl versions as old as 5.8.3, so your tests will
be expected to pass on that.
Also, do not use any non-core Perl modules except IPC::Run.
Or, if you must do so for a particular test, arrange to skip
the test when the needed module isn't present.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-10-07 19:51:49 | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |
Previous Message | Tom Lane | 2021-10-07 19:37:02 | pgsql: Doc: update our claims about the minimum recommended AIX version |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2021-10-07 19:47:19 | Re: storing an explicit nonce |
Previous Message | Stephen Frost | 2021-10-07 19:38:58 | Re: storing an explicit nonce |