Re: Converting tab-complete.c's else-if chain to a switch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Converting tab-complete.c's else-if chain to a switch
Date: 2024-10-07 16:33:25
Message-ID: 1729572.1728318805@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Mon, Oct 7, 2024 at 12:11 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hmm, I should think that if you break anything in tab-complete.in.c,
>> the breakage would propagate to tab-complete.c without difficulty.
>> Do you have an example of something that the preprocessor would mask?

> Fair point, and nope. Thought withdrawn.

Pushed, then.

The original motivation for all this was to try to get tab completion
working in MSVC builds. I'm not planning to do anything more towards
that myself, but maybe somebody else would like to have a go at it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2024-10-07 16:41:12 Re: POC, WIP: OR-clause support for indexes
Previous Message David G. Johnston 2024-10-07 16:30:28 Re: Psql meta-command conninfo+