| From: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Hunaid Sohail <hunaidpgml(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add roman support for to_number function |
| Date: | 2024-09-07 18:51:29 |
| Message-ID: | 172573508957.1127.13514581275952642481.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, passed
Tested again, and the patch looks good. It does not accept leading or trailing whitespace, which seems reasonable, given the unclear behavior of to_number with other format strings. It also rejects less common Roman spellings like "IIII". I don't feel strongly about that one way or the other, but perhaps a test codifying that behavior would be useful to make it clear it's intentional.
I'm marking it RfC.
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maciek Sakrejda | 2024-09-07 18:57:00 | Re: [PATCH] Add roman support for to_number function |
| Previous Message | Jonathan S. Katz | 2024-09-07 18:44:37 | Re: PostgreSQL 17 release announcement draft |