Re: pl/pgSQL, get diagnostics and big data

"Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de> writes:
> On 09.02.2016 20:32, Christian Ullrich wrote:
>> To fix this, I think it will be enough to change the format strings to
>> use "%zu" instead of "%lu".

> Attached is a new version of the patch, with %lu replaced by %zu.

Nonono ... that just moves the portability problem to a different set of
platforms. "%z" means size_t, and sizeof(size_t) is not any more fixed
than sizeof(long). The right thing to use is UINT64_FORMAT.

+ /* Int64GetDatum() instead of UInt64GetDatum(),
+ because there is no UInt64GetDatum() */
+ Int64GetDatum(estate->eval_processed),

Although in practice you'd get the same conversion anyway, I'm thinking
it's time to fix that omission rather than just averting our eyes. The
use of int64 data isn't decreasing as time goes on.

These are small enough changes that there's no need for a new patch
submission. I'll take it from here, unless I find bigger issues.

regards, tom lane