Re: [HACKERS] 0x1A in control file on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [HACKERS] 0x1A in control file on Windows
Date: 2008-09-24 02:36:09
Message-ID: 17234.1222223769@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> pg_controldata is certainly already being read as binary.

> Umm, no, it is in the backend I believe but not in the utilities. Hence
> the original bug report. We need to add the binary flag in
> pg_controldata.c and pg_resetxlog.c.

Ah, okay, that's surely a bug. But I think the discussion here was
about adding PG_BINARY to *all* open requests. That I don't like.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2008-09-24 03:16:44 Re: BUG #4435: pg_ctl start doesn't detach when run via SSH
Previous Message Andrew Dunstan 2008-09-24 02:17:46 Re: [HACKERS] 0x1A in control file on Windows

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2008-09-24 02:43:19 Updates of SE-PostgreSQL 8.4devel patches
Previous Message Andrew Dunstan 2008-09-24 02:17:46 Re: [HACKERS] 0x1A in control file on Windows