| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, rmt(at)lists(dot)postgresql(dot)org, horikyota(dot)ntt(at)gmail(dot)com |
| Subject: | Re: psql: Add role's membership options to the \du+ command |
| Date: | 2023-07-08 17:07:21 |
| Message-ID: | 1721887.1688836041@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> writes:
> Please find attached new patch version.
> It implements \drg command and hides duplicates in \du & \dg commands.
I took a quick look through this, and have some minor suggestions:
1. I was thinking in terms of dropping the "Member of" column entirely
in \du and \dg. It doesn't tell you enough, and the output of those
commands is often too wide already.
2. You have describeRoleGrants() set up to localize "ADMIN", "INHERIT",
and "SET". Since those are SQL keywords, our usual practice is to not
localize them; this'd simplify the code.
3. Not sure about use of LEFT JOIN in the query. That will mean we
get a row out even for roles that have no grants, which seems like
clutter. The LEFT JOINs to r and g are fine, but I suggest changing
the first join to a plain join.
Beyond those nits, I think this is a good approach and we should
adopt it (including in v16).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joseph Koshakow | 2023-07-08 17:18:32 | Re: DecodeInterval fixes |
| Previous Message | Tom Lane | 2023-07-08 16:08:52 | Re: Cleaning up array_in() |