| From: | Yasir Shah <yasir(dot)hussain(dot)shah(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows |
| Date: | 2024-07-16 11:57:37 |
| Message-ID: | 172113105761.344725.7570284373523963080.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation: not tested
Hi,
I have verified following:
- Bug exits in PG17. I also checked it in PG16 but it does not exits there.
- After applying your patch, I can confirm that bug get fixed.
- no regression found. I ran "meson test".
- I would like to suggest you that #includes should be included at appropriate location keeping the #includes alphabetically sorted, what I observed in the PG code as a standard:
Your patch:
#include <versionhelpers.h>
#include <tlhelp32.h>
It should be like:
#include <tlhelp32.h>
#include <versionhelpers.h>
Regards...
Yasir Hussain
Bitnine Global Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yasir | 2024-07-16 12:04:31 | Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows |
| Previous Message | Floris Van Nee | 2024-07-16 11:47:06 | temp table on commit delete rows performance issue |