Re: pgsql: Suppress compiler warnings in ecpg test on newer Windows toolcha

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Suppress compiler warnings in ecpg test on newer Windows toolcha
Date: 2017-03-08 20:41:11
Message-ID: 17189.1489005671@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> On 25 February 2017 at 10:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Suppress compiler warnings in ecpg test on newer Windows toolchains.

> This seems to have caused some new compiler warnings [1] on earlier
> MSVC toolchains.

That didn't make any sense to me, because the commit you mention only
touched one ecpg test file. But closer inspection of thrips' buildfarm
history says that the warnings appeared with commit c29aff959, which
does make sense, because that removed <float.h> from a header file that
these .c files must have been getting it from.

Fix pushed, thanks for noticing.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-03-08 21:10:34 pgsql: Suppress compiler warning in non-USE_LIBXML builds.
Previous Message Tom Lane 2017-03-08 20:38:44 pgsql: Put back <float.h> in a few files that need it for _isnan().