Re: Skytools committed without hackers discussion/review

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 15:26:54
Message-ID: 17173.1192030014@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Marko Kreen wrote:
>> Also I think several people are annoyed by the "Jan asked permission
>> from -core" part of the process.

> I don't think this is accurate. Jan talked to Tom, not all of core, and
> Tom just gave general approval. Tom still expected this to go through
> the hackers review process.

Well, my view of the discussion was that Jan asked core if any of us
would veto a late contrib addition. I trust you'll agree that if anyone
on core were to vote against, it would not have gone in; and so it
seemed reasonable to me for Jan to check this before expending any
further effort on creating a patch.

I asked a couple questions and then said it sounded okay to me; I don't
recall now if anyone else commented, but this was definitely a
discussion on -core not personal email.

In any case, since that was in advance of seeing the code, I certainly
was expecting a -patches submission before commit ...

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-10-10 15:30:47 Re: Skytools committed without hackers discussion/review
Previous Message User Fxjr 2007-10-10 15:21:01 npgsql - Npgsql2: Updated BSD License

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-10-10 15:30:47 Re: Skytools committed without hackers discussion/review
Previous Message Tom Lane 2007-10-10 15:15:58 Re: Locale + encoding combinations