From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction. |
Date: | 2011-01-26 16:05:32 |
Message-ID: | 17140.1296057932@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Jan 26, 2011 at 10:36 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This is not an "arbitrary restriction" because according to the SQL
>> standard those operations mean different things. In the first case you
>> get a column filled with the default value, in the second case you get a
>> column filled with nulls. And the latter case is the only one that
>> works properly with a rowtype.
> That's an untenable interpretation.
No, *your* interpretation is untenable. The sequence of operations that
the previous coding allowed behaves the same for both the table and
rowtype instances. The "shortcut" doesn't behave the same.
This was, I believe, discussed at length when the previous coding was
put in. The fact that you and Noah haven't read the spec carefully
doesn't give you license to change it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-01-26 16:33:12 | Re: [COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction. |
Previous Message | Bruce Momjian | 2011-01-26 16:03:24 | pgsql: In pg_test_fsync, use K(1024) rather than k(1000) for write size |
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Tiikkaja | 2011-01-26 16:07:01 | Re: REVIEW: EXPLAIN and nfiltered |
Previous Message | Kevin Grittner | 2011-01-26 16:01:28 | Re: SSI patch version 14 |