| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bug fix for glibc broke freebsd build in REL_11_STABLE |
| Date: | 2018-09-05 14:05:26 |
| Message-ID: | 17115.1536156326@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 05/09/2018 02:51, Andres Freund wrote:
>> My current proposal is thus to do add a check that does
>> #if defined(__clang__) && defined(__i386__) && !defined(__SSE2_MATH__)
>> something-that-fails
>> #endif
>> in an autoconf test, and have configure complain if that fails.
> Would this not be invalidated if the bug you have filed gets fixed?
Perhaps, but how would autoconf tell that? I wouldn't have any confidence
in a runtime test, as it might or might not trigger the bug depending on
all sorts of factors like -O level.
In any case, it seems like "use -msse2 on x86" is good advice from a
performance standpoint even if it doesn't prevent a compiler bug.
One thought is that maybe we should provide a way to override this,
in case somebody really can't or doesn't want to use -msse2, and
is willing to put up with platform-dependent float behavior.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-09-05 14:05:40 | Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun |
| Previous Message | Adrian Klaver | 2018-09-05 14:00:03 | Re: unaccent(text) fails depending on search_path (WAS: pg_upgrade fails saying function unaccent(text) doesn't exist) |