| From: | David Christensen <david+pg(at)pgguru(dot)net> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Subject: | Re: Avoiding inadvertent debugging mode for pgbench |
| Date: | 2024-03-21 19:42:24 |
| Message-ID: | 171105014486.2046434.7488974502048570210.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: tested, passed
Did a quick review of this one; CFbot is now happy, local regression tests all pass.
I think the idea here is sane; it's particularly confusing for some tools included in the main distribution to have different semantics, and this seems low on the breakage risk here, so worth the tradeoffs IMO.
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wolfgang Walther | 2024-03-21 20:16:46 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Previous Message | Tom Lane | 2024-03-21 19:42:14 | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |