From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | Mahadevan Ramachandran <mahadevan(at)rapidloop(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15245: pg_stat_all_tables does not include partition master tables |
Date: | 2018-06-18 09:48:10 |
Message-ID: | 16ac0ae3-f0ba-536f-92e2-4a954dce8bbf@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On 2018/06/18 11:06, Michael Paquier wrote:
> On Sun, Jun 17, 2018 at 08:29:33AM -0700, David G. Johnston wrote:
>> My first reaction was to agree, which suggests a need for a note in the
>> docs why this isn't the case. The _all_ specifically means both user and
>> system; the _stats_ in the name means that only tables that have statistics
>> are included. I feel this is a reasonable decision.
>
> If there were anything to happen here, then I think that it would be
> hard to define what the statistics of the parent partition should
> reflect. For example, the autovacuum and autoanalyze run times are I
> think tricky as you cannot really define the last time autovacuum has
> been run on the parent as the last time it has been run only only one of
> the partitions or a sub-set of them. This gets also messier if you come
> across multiple partition layers.
I think autovacuum launcher ignores/skips relkind 'p' relations. Also, we
don't emit any kind of statistics for relkind 'p' relations to the stats
collector, as individual inserts/deletes into such relations are rather
counted as insert/deletes on partitions into which they're routed.
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2018-06-18 10:00:37 | Re: BUG #15245: pg_stat_all_tables does not include partition master tables |
Previous Message | Amit Langote | 2018-06-18 09:27:21 | Re: BUG #15245: pg_stat_all_tables does not include partition master tables |