Re: pg_basebackup's --gzip switch misbehaves

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_basebackup's --gzip switch misbehaves
Date: 2022-11-14 12:36:56
Message-ID: 16ECB8FA-F710-4C14-BC82-804CF3E810C1@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Nov 2022, at 12:49, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Nov 02, 2022 at 09:42:12PM +0100, Daniel Gustafsson wrote:
>> I think that's a good idea, not everyone running tests will read the internals
>> documentation (or even know abou it even). How about the attached?
>
> Thanks for the patch. Perhaps this should be mentioned additionally
> in install-windows.sgml? I have not tested, but as long as these
> variables are configured with a "set" command in a command prompt,
> they would be passed down to the processes triggered by vcregress.pl
> (see for example TESTLOGDIR and TESTDATADIR).

That's probably a good idea, I've amended the patch with that and also made the
CPAN mention of IPC::Run into a ulink like how it is in the Windows section in
passing. To avoid duplicating the info in the docs I made it into a sect2
which can be linked to. How about this version?

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
regress_tap-v2.diff application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2022-11-14 12:37:27 Re: when the startup process doesn't (logging startup delays)
Previous Message Ian Lawrence Barwick 2022-11-14 12:08:46 Re: Commit fest 2022-11