Re: strange infinite loop in plpgsql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: rihad(at)mail(dot)ru
Cc: pgsql-general(at)postgresql(dot)org
Subject: Re: strange infinite loop in plpgsql
Date: 2007-11-10 17:36:34
Message-ID: 16944.1194716194@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

rihad <rihad(at)mail(dot)ru> writes:
> LOOP
> SELECT date+1 INTO day FROM days WHERE date=day OR EXTRACT(dow
> FROM day) IN (0,6);
> EXIT WHEN NOT FOUND;
> timeout := timeout + 86400;
> END LOOP;

If the EXTRACT condition is true, then the SELECT will always succeed.
This code will get even more whacko once you have more than one row
in "days", because it'll pick a random one of the rows in that case
(in practice, the physically first one). I think you need something
more like

LOOP
IF EXTRACT(dow FROM day) IN (0,6) THEN
-- don't bother to consult table on weekends
day := day + 1;
ELSE
SELECT date+1 INTO day FROM days WHERE date=day;
EXIT WHEN NOT FOUND;
END IF;
timeout := timeout + 86400;
END LOOP;

BTW, you forgot to initialize "timeout".

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2007-11-10 17:50:14 Re: (Never?) Kill Postmaster?
Previous Message Vyacheslav Kalinin 2007-11-10 17:21:48 Re: strange infinite loop in plpgsql