From: | Tristen Raab <tristen(dot)raab(at)highgo(dot)ca> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Cc: | Jelte Fennema <github-tech(at)jeltef(dot)nl> |
Subject: | Re: Allow specifying a dbname in pg_basebackup connection string |
Date: | 2023-08-28 21:49:41 |
Message-ID: | 169325938134.1124.11129493970278129501.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hello,
I've reviewed your patch and it applies and builds without error. When testing this patch I was slightly confused as to what its purpose was, after testing it I now understand. Initially, I thought this was a change to add database-level replication. I would suggest some clarifications to the documentation such as changing:
"supplying a specific database name in the connection string won't cause PostgreSQL to behave any differently."
to
"supplying a specific database name in the connection string won't cause pg_basebackup to behave any differently."
I believe this better illustrates that we are referring to the actual pg_basebackup utility and how this parameter is only used for proxies and bears no impact on what pg_basebackup is actually doing. It also would remove any confusion about database replication I had prior.
There is also a small typo in the same documentation:
"However, if you are connecting to PostgreSQL through a proxy, then it's possible that this proxy does use the supplied databasename to make certain decisions, such as to which cluster to route the connection."
"databasename" is just missing a space.
Other than that, everything looks good.
Regards,
Tristen
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2023-08-28 22:00:56 | Re: A failure in 031_recovery_conflict.pl on Debian/s390x |
Previous Message | Tatsuo Ishii | 2023-08-28 21:12:00 | Re: Wrong usage of pqMsg_Close message code? |