Re: change do_tup_output to take Datum arguments rather than cstring

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: change do_tup_output to take Datum arguments rather than cstring
Date: 2009-07-22 17:03:49
Message-ID: 169.1248282229@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jun 15, 2009 at 1:20 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> it looks like I can probably rip that member out of TupOutputState
>>> altogether.
>>
>> Yeah, that's exactly what I was thinking.

> Excellent. Revised patch attached.

Applied with minor editorialization.

It strikes me that it would now be quite easy to make the
efficiency improvement alluded to in do_tup_output's comment:

* XXX This could be made more efficient, since in reality we probably only
* need a virtual tuple.

but I didn't have time to investigate that right now (got to leave for
a dentist appointment :-()

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2009-07-22 17:40:29 Re: revised hstore patch
Previous Message David E. Wheeler 2009-07-22 16:13:39 Re: revised hstore patch