| From: | Tristen Raab <tristen(dot)raab(at)highgo(dot)ca> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: pg_waldump: add test for coverage |
| Date: | 2023-06-29 19:16:52 |
| Message-ID: | 168806621290.1114.6526720863694392620.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hello,
I've reviewed your latest v3 patches on Ubuntu 23.04. Both patches apply correctly and all the tests run and pass as they should. Execution time was normal for me, I didn't notice any significant latency when compared to other tests. The only other feedback I can provide would be to add test coverage to some of the other options that aren't currently covered (ie. --bkp-details, --end, --follow, --path, etc.) for completeness. Other than that, this looks like a great patch.
Kind regards,
Tristen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2023-06-29 19:17:30 | Re: Meson build updates |
| Previous Message | Andres Freund | 2023-06-29 19:13:08 | Re: Meson build updates |