Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: "Guo, Adam" <adamguo(at)amazon(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation
Date: 2024-04-30 16:54:51
Message-ID: 1685377.1714496091@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> Given this, should we try to do better with binary compatibility
> checks using ControlFileData? AFAICS they are supposed to check if
> the database cluster is binary compatible with the running
> architecture. But it obviously allows incompatibilities.

Perhaps. pg_control already covers endianness, which I think
is the root of the hashing differences I showed. Adding a field
for char signedness feels a little weird, since it's not directly
a property of the bits-on-disk, but maybe we should.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2024-04-30 17:00:00 Re: Avoid orphaned objects dependencies, take 3
Previous Message Alexander Korotkov 2024-04-30 16:43:12 Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation