| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove useless casts to (void *) |
| Date: | 2024-12-02 22:11:30 |
| Message-ID: | 1685317.1733177490@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> I wouldn't change that. illumos is selecting the old pre-standard
> declaration here, but it knows the standard one:
> https://github.com/illumos/illumos-gate/blob/27ecbff00d8c86a2647d6fe325cacb220d712115/usr/src/uts/common/sys/shm.h#L129
> https://illumos.org/man/2/shmdt
Oh! Kind of looks like we should be defining _POSIX_C_SOURCE=200112L,
at least on that platform.
> I don't know why we have only one tiny issue if the system headers
> think we want pre-POSIX stuff.
Agreed, I'd have expected more trouble than this. But persuading
the system headers that we want a POSIX version from this century
seems like it might be a good idea to forestall future issues.
I'm inclined to propose adding something like
CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
to src/template/solaris. Not sure if we have a corresponding
mechanism for meson, though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-12-02 22:23:37 | Re: Remove useless casts to (void *) |
| Previous Message | Peter Geoghegan | 2024-12-02 22:10:45 | Re: Incorrect result of bitmap heap scan. |