Re: CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful
Date: 2014-05-29 20:42:31
Message-ID: 16847.1401396151@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <pg(at)heroku(dot)com> writes:
> On Thu, May 29, 2014 at 1:34 PM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> Also checking that CritSectionCount == 0 seems like a good idea...

> What do you do if it isn't?

Not throw the error. (If we did, it'd turn into a PANIC, which doesn't
seem like what we want.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2014-05-29 20:44:06 Re: Extended Prefetching using Asynchronous IO - proposal and patch
Previous Message Tom Lane 2014-05-29 20:41:37 Re: CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful