Re: pg_type_d.h location incorrect

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, May 26, 2021 at 05:40:45AM +0000, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
>> You're right, backtick notation doesn't work at my windows machine.
>> But I made the fix in accordance with the pg-doc as below. So maybe
>> we need a fix there, too?
>>
>> https://www.postgresql.org/docs/current/libpq-pgservice.html
>> a system-wide file at `pg_config --sysconfdir`/pg_service.conf

> Using catalog/pg_type_d.h sounds enough to me as well. While on it,
> we could adjust include/common/relpath.h in pgbuffercache.sgml? We
> tend to include the full path for things not generated.

I doubt we can drop the reference to pg_config in libpq-pgservice.html,
because otherwise we'd have to just say "etc/" which is not very
definite. However, we should avoid the use of backticks since that's
a platform-specific thing.

I set out to rewrite that, but the more I looked at that section the
more help it seemed to need. I thought the para was quite confusing
about which environment variables affect what; and I also noticed
that nowhere do we explain how service-file settings interact with
other settings. (If that had been better specified to begin with,
maybe I'd not have made the mistake fixed in ea8013854.)

So I ended up with the attached --- what do you think?

Also, looking at this, I note that "~/.pg_service.conf" is still a
platform-ism. We could make that slightly better by writing
"$HOME/.pg_service.conf", but is that good enough?

regards, tom lane