| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() |
| Date: | 2010-06-07 15:45:18 |
| Message-ID: | 16807.1275925518@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> This commit changed walsender so that it doesn't call set_ps_display() if
> update_process_title = off.
Yeah. The idea is to not waste time on a useless snprintf() call when the
GUC is turned off.
> On the other hand, walreceiver doesn't check
> update_process_title. Though this check might not be required since it's
> within set_ps_display(), we should do that for the sake of consistency?
Seems reasonable to make the same minor optimization on that side.
Will commit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-06-07 15:49:30 | pgsql: Avoid useless snprintf() call when update_process_title is turned |
| Previous Message | Teodor Sigaev | 2010-06-07 15:15:16 | pgsql: Add missed function dblink_connect_u(text[, text]) to uninstall |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2010-06-07 15:45:47 | pgstatindex still throws ERROR: value "3220078592" is out of range for type integer |
| Previous Message | Tom Lane | 2010-06-07 15:42:05 | Re: SR slaves and .pgpass |