Re: BUG #18618: pg_upgrade from 14 to 15+ fails for unlogged table with identity column

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: erwaman(at)gmail(dot)com, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: BUG #18618: pg_upgrade from 14 to 15+ fails for unlogged table with identity column
Date: 2024-09-17 19:56:13
Message-ID: 1680623.1726602973@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
>> The only alternative I can see is to extend the ALTER TABLE ADD
>> GENERATED syntax to allow correct specification of the sequence's
>> LOGGED/UNLOGGED status to begin with. While cleaner, that would be
>> a lot more work and probably result in compatibility problems for
>> normal uses of pg_dump (where the output might get loaded into a
>> server version that lacks the syntax extension).

> So we have to do it like that, and it seems not that bad, especially
> if we follow the lead of the SEQUENCE NAME option and don't bother
> to document this stuff. (I don't think that's a great precedent,
> but I didn't change it here.)

Pushed with a bit of further polishing, including adding that
missing documentation.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2024-09-17 20:00:02 Re: PL/pgSQL THEN binging in condition
Previous Message Pavel Stehule 2024-09-17 18:45:55 Re: PL/pgSQL THEN binging in condition