From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through |
Date: | 2005-10-13 02:46:14 |
Message-ID: | 16771.1129171574@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Does any of this need to be backpatched?
No --- we didn't have any per-buffer spinlocks before 8.1.
It's possible that at some point we'll need to start thinking about
applying volatile-pointer coding rules to data structures protected by
LWLocks. This could only become an issue if the compiler (a) inlines
LWLockAcquire/Release, and (b) tries to rearrange loads and stores
around the LWLock code. I would like to think that the latter is
impossible even with inlining, principally because the compiler can't
ignore the kernel calls that may occur within the LWLock routines;
those should be treated as external function calls and hence sequence
points, no matter how aggressive the compiler gets. But we'll see.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2005-10-13 03:28:27 | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer |
Previous Message | Bruce Momjian | 2005-10-13 02:29:32 | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through |
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2005-10-13 03:28:27 | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer |
Previous Message | Bruce Momjian | 2005-10-13 02:29:32 | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through |