Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg

Vlad <marchenko(at)gmail(dot)com> writes:
> diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c
> --- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005
> +++ DBD-Pg-1.41-patched/types.c Fri Apr 8 15:46:37 2005
> @@ -55,7 +55,7 @@
> {ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}},
> {RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}},
> {TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}},
> - {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}},
> + {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, null_dequote, {0}},
> {CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}},
> {CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}},
> {MACADDROID, "MAC address", DBDPG_TRUE,
> quote_varchar,dequote_varchar, {0}},

Hmm ... if those columns mean what it looks like they mean, quite a few
of the other entries seem wrong too. All of the types visible in that
fragment ought to be quoted when used as SQL literals.

Also, if the MACADDROID entry is any precedent, shouldn't you be
changing the dequote field too?

regards, tom lane