| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, "Augustine, Jobin" <jobin(dot)augustine(at)openscg(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Replication to Postgres 10 on Windows is broken |
| Date: | 2017-08-06 22:17:17 |
| Message-ID: | 16750.1502057837@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-08-06 18:04:49 -0400, Tom Lane wrote:
>> io_flag has to be *just* the I/O condition, because we use it in a test
>> after the WaitLatchOrSocket call.
> Hm, right. Wouldn't be particularly consequential,
Yes, it would be. The entire point of this loop is to avoid blocking
in PQconnectPoll, and that's not guaranteed unless we honor the contract
of only calling it when we've gotten the read-ready or write-ready status
it asked for.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaimin Pan | 2017-08-07 07:45:16 | Error of insert Foreign table with postgres_fdw |
| Previous Message | Andres Freund | 2017-08-06 22:10:42 | Re: Replication to Postgres 10 on Windows is broken |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-08-07 00:07:35 | ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values) |
| Previous Message | Andres Freund | 2017-08-06 22:10:42 | Re: Replication to Postgres 10 on Windows is broken |