Re: [PATCH] Store Extension Options

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Store Extension Options
Date: 2014-03-13 15:11:51
Message-ID: 16723.1394723511@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-03-13 10:26:11 -0400, Tom Lane wrote:
>> No, because relcache doesn't store security labels to start with.
>> There's a separate catalog cache for security labels, I believe,
>> and invalidating entries in that ought to be sufficient.

> There doesn't seem to be any form of system managed cache for security
> labels afaics. Every lookup does a index scan. I currently don't see how
> I could build a cache in userland that'd invalidate if either a) the
> underlying object changes b) the label changes.

If there's not a catcache for pg_seclabels, I'd have no objection
to adding one. As for your "userland cache" objection, you certainly
could build such a thing using the existing inval callbacks (if we
had a catcache on pg_seclabels), and in any case what have userland
caches got to do with relcache?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-03-13 15:15:56 Re: [PATCH] Store Extension Options
Previous Message Greg Stark 2014-03-13 14:49:19 Re: jsonb and nested hstore