| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17855: Uninitialised memory used when the name type value processed in binary mode of Memoize |
| Date: | 2024-04-30 14:54:03 |
| Message-ID: | 1670904.1714488843@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> I think this is a good idea. It seems reasonable that some other AM
> might want to do the same thing. Also, it allows me to choose a better
> name for these new IndexOnlyScanState fields. ioss_NameCStringAttNums
> and ioss_NameCStringCount seems more on point. However, I couldn't
> really decide which way around to have Name and CString.
This version LGTM. The field names are fine, or at least I don't see
a reason to prefer the other way. One trivial nit: should we make
the array be AttrNumber* instead of int*? The space saving would be
negligible (it being very unlikely that there's ever more than one
entry), but AttrNumber is a more specific description of what it is.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-04-30 15:00:00 | Re: BUG #17855: Uninitialised memory used when the name type value processed in binary mode of Memoize |
| Previous Message | Sandeep Thakkar | 2024-04-30 05:41:37 | Re: Re: edb installation failed for pgadmin when username is Chinese under c;\user #7432 |