| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Allow specification of custom slot for custom nodes |
| Date: | 2022-11-21 13:33:30 |
| Message-ID: | 166903761072.1121.2757138082242561269.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionality unless anyone (e.g. extension) sets its own slotOps in CustomScanState.
Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing extensibility. So I think adding more extensibility regarding different tuple formats is an excellent thing to do.
I'm going to mark it as RfC if there are no objections.
Kind regards,
Pavel Borisov,
Supabase
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-11-21 13:36:41 | Re: Allow single table VACUUM in transaction block |
| Previous Message | Drouvot, Bertrand | 2022-11-21 13:32:31 | Re: Split index and table statistics into different types of stats |