| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Guyren Howe <guyren(at)gmail(dot)com>, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Please provide examples of rows from |
| Date: | 2020-09-24 19:05:24 |
| Message-ID: | 1668963.1600974324@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Yes, this is very helpful. I was afraid the JSON would overwhelm the
> example, but this looks good. I wrote the attached doc patch which I
> think improves this. I plan to apply it to all supported versions.
Couple thoughts:
* Taking the initial ... out of the syntax synopsis is not an improvement.
It makes it look like you can only apply AS to the first function of a
ROWS FROM.
* I think the ORDER BY adds nothing to the example except complication
and confusion.
* Maybe the other sentence of explanation would read better as
json_to_recordset() is instructed to return two columns,
the first integer and the second text. The result of
generate_series() is used directly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-09-24 19:37:14 | Re: Please provide examples of rows from |
| Previous Message | Bruce Momjian | 2020-09-24 18:55:11 | Re: Please provide examples of rows from |