Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based
Date: 2020-09-07 14:48:46
Message-ID: 1668181.1599490126@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2020-Sep-07, Pavel Stehule wrote:
>> I tried to reuse this new API in pg_dump.c, and I had a problem with
>> private struct StringInfo.

>> maybe there should be included directly with #include "lib/stringinfo.h" ?

> That's the right thing to do, yes.

Yeah, if you want to use pg_get_line_append, you need to include
both those headers.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-09-07 16:03:09 pgsql: Frob numeric.c loop so that clang will auto-vectorize it too.
Previous Message Alvaro Herrera 2020-09-07 14:29:35 Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based