From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: "debug_invalidate_system_caches_always" is too long |
Date: | 2021-07-06 13:24:28 |
Message-ID: | 1664806.1625577868@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 7/5/21 11:46 PM, Bharath Rupireddy wrote:
>> On Tue, Jul 6, 2021 at 12:43 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I like "debug_flush_caches" --- it's short and accurate.
>> Do we always flush the cache entries into the disk? Sometimes we just
>> invalidate the cache entries in the registered invalidation callbacks,
>> right? Since we already use the term "clobber" in the user visible
>> config option --clobber-cache, isn't it consistent to use
>> debug_clobber_caches?
> I think 'flush' here means simply 'discard'. Maybe that would be a
> better word to use.
"Discard" could be misinterpreted too, no doubt. None of these words
have one single exact meaning, so I have only limited patience for
this sort of argumentation.
(As for initdb's "--clobber-cache", I'm assuming we'd rename that to
match whatever we come up with here. It is what it is now only because
I was unwilling to call it "--use-debug-invalidate-system-caches-always".)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2021-07-06 13:34:58 | Re: .ready and .done files considered harmful |
Previous Message | James Coleman | 2021-07-06 13:19:36 | Re: [PATCH] Use optimized single-datum tuplesort in ExecSort |