| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3) |
| Date: | 2018-03-17 19:25:57 |
| Message-ID: | 16480.1521314757@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I don't think performance is a prime driver here, or shouldn't be at least. Obviousness / grepability seem much more important. I'd vote for using my version in master, and yours in the back branches. I can do that, of you want.
I dunno, I think the code as I had it is quite obvious. It's just that
I don't really like hard-coding references to INT_MIN/MAX, which I guess
is a personal style thing rather than anything I can defend well.
> I'm OK with skipping the test for now.
If we're not putting a test into the back branches, then we darn well
better be using the same code there as in HEAD, else we won't know that
it actually solves the problem.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2018-03-17 19:32:12 | Re: MCV lists for highly skewed distributions |
| Previous Message | Andres Freund | 2018-03-17 19:17:48 | Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3) |