Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Binderman <dcb314(at)hotmail(dot)com>
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?
Date: 2017-10-06 15:37:05
Message-ID: 16439.1507304225@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

David Binderman <dcb314(at)hotmail(dot)com> writes:
>> Huh ... that code's been like that since 2006.  Odd that nothing's
>> noticed the dead-ness before.  What tool were you using?

> cppcheck, available from sourceforge.

Thanks. I've corrected this in HEAD, but it seems not worth
back-patching since it's really just cosmetic.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Josef Machytka 2017-10-06 15:42:08 Re: BUG #14845: postgres_fdw and mysql_fdw can cause crash of instance
Previous Message David Binderman 2017-10-06 15:18:07 postgresql-10.0/src/backend/optimizer/geqo/geqo_ox2.c:84:sanity check after use ?