Re: buildfarm breakage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: buildfarm breakage
Date: 2010-02-09 16:11:41
Message-ID: 16389.1265731901@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Here's a patch that "fixes" this. I put it locally for the radius
> authentication for now, since we don't use this anywhere else. Should
> we put this in /port/ somewhere, or is this good for now?

How about dropping it in src/backend/port/win32/mingwcompat.c ?

The advantage of putting it in src/port/ is that it would possibly
help client-side code sometime in future. But what seems more likely
to happen is that the mingw people will fix their oversight, and
then we'd be risking link conflicts, which will be harder to fix on
the client side. So I'm inclined to not go there as long as we
don't actually need it on client side. But putting mingw hacks
in a mingw-specific place seems a good idea.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-02-09 16:14:06 Re: bugfix - VIP: variadic function ignore strict flag
Previous Message Pavel Stehule 2010-02-09 15:45:22 bugfix - VIP: variadic function ignore strict flag