| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Sravan Kumar <sravanvcybage(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_verifybackup: TAR format backup verification |
| Date: | 2024-09-30 22:05:56 |
| Message-ID: | 1636825.1727733956@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Sep 30, 2024 at 11:31 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> WFM, modulo the suggestion about changing data types.
> I would prefer not to make the data type change here because it has
> quite a few tentacles.
I see your point for the function's "len" argument, but perhaps it's
worth doing
- int remaining;
+ size_t remaining;
remaining = sizeof(ControlFileData) - mystreamer->control_file_bytes;
memcpy(((char *) &mystreamer->control_file)
+ mystreamer->control_file_bytes,
- data, Min(len, remaining));
+ data, Min((size_t) len, remaining));
This is enough to ensure the Min() remains safe.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-30 22:20:41 | Re: pg_upgrade check for invalid databases |
| Previous Message | Daniel Gustafsson | 2024-09-30 22:04:14 | Re: ACL_MAINTAIN, Lack of comment content |